bpo-46709: check eval breaker in specialized CALL opcodes
#31404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the race? |
markshannon
reviewed
Feb 18, 2022
markshannon
reviewed
Feb 18, 2022
markshannon
reviewed
Feb 18, 2022
markshannon
reviewed
Feb 18, 2022
sobolevn
changed the title
unittest/test_brakeCALL opcodes
|
Thank you! Removed extra ones. 👍
Sorry, this was from the #31273, new wording should be better. |
|
Thanks for picking this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
CHECK_EVAL_BREAKER()to all specialized opcodes. This needs to be double checkedwithRepeats()helper test method to run the test case several times. They were failing beforeCHECK_EVAL_BREAKER()additions, but now they pass!Replaces:
unittest/test_brake#31273CALLopcodes #30826Bugs:
https://bugs.python.org/issue46709
https://bugs.python.org/issue46465