Skip to content

Removed ambiguity in __init_subclass__ docs #31540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

davidgilbertson
Copy link
Contributor

Reading this for the first time, not knowing what the method does, I couldn't work out which class "that class" referred to (obviously it becomes clear once you know what the method does).

@kumaraditya303
Copy link
Contributor

@JelleZijlstra This is ready for merge.

@JelleZijlstra JelleZijlstra self-assigned this Mar 3, 2022
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another small docs improvement I'd like to merge (cc @gvanrossum).

There is actually a more precise description of what __init_subclass__ does on line 1982-3 below. The proposed change here is more informal and I think it improves clarity.

@JelleZijlstra JelleZijlstra merged commit ab01497 into python:main Mar 8, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Mar 8, 2022
@miss-islington
Copy link
Contributor

Thanks @davidgilbertson for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @davidgilbertson for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 8, 2022
@bedevere-bot
Copy link

GH-31748 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Mar 8, 2022
@bedevere-bot
Copy link

GH-31749 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2022
(cherry picked from commit ab01497)

Co-authored-by: David Gilbertson <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2022
(cherry picked from commit ab01497)

Co-authored-by: David Gilbertson <[email protected]>
@JelleZijlstra
Copy link
Member

I'm glad @miss-islington listens to backport labels even after a merge :)

@gvanrossum
Copy link
Member

I'm glad @miss-islington listens to backport labels even after a merge :)

She's very smart.

miss-islington added a commit that referenced this pull request Mar 8, 2022
(cherry picked from commit ab01497)

Co-authored-by: David Gilbertson <[email protected]>
miss-islington added a commit that referenced this pull request Mar 8, 2022
(cherry picked from commit ab01497)

Co-authored-by: David Gilbertson <[email protected]>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
(cherry picked from commit ab01497)

Co-authored-by: David Gilbertson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants