-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
Removed ambiguity in __init_subclass__ docs #31540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@JelleZijlstra This is ready for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another small docs improvement I'd like to merge (cc @gvanrossum).
There is actually a more precise description of what __init_subclass__
does on line 1982-3 below. The proposed change here is more informal and I think it improves clarity.
Thanks @davidgilbertson for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
Thanks @davidgilbertson for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
GH-31748 is a backport of this pull request to the 3.10 branch. |
GH-31749 is a backport of this pull request to the 3.9 branch. |
(cherry picked from commit ab01497) Co-authored-by: David Gilbertson <[email protected]>
(cherry picked from commit ab01497) Co-authored-by: David Gilbertson <[email protected]>
I'm glad @miss-islington listens to backport labels even after a merge :) |
She's very smart. |
(cherry picked from commit ab01497) Co-authored-by: David Gilbertson <[email protected]>
(cherry picked from commit ab01497) Co-authored-by: David Gilbertson <[email protected]>
(cherry picked from commit ab01497) Co-authored-by: David Gilbertson <[email protected]>
Reading this for the first time, not knowing what the method does, I couldn't work out which class "that class" referred to (obviously it becomes clear once you know what the method does).