bpo-46430: Add test for checking block leak is zero #31556
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaraditya303
requested changes
Feb 24, 2022
| @@ -125,6 +126,9 @@ def run_python(*args): | |||
| # because of bugs in C extensions. This test is only about checking | |||
| # the showrefcount feature. | |||
| self.assertRegex(err, br'^\[-?\d+ refs, \d+ blocks\]') | |||
| refs, blocks = map(int, re.findall(r'-?\d+', str(err))) | |||
| self.assertLessEqual(refs, 0) | |||
There was a problem hiding this comment.
Refs should be 0 not negative.
There was a problem hiding this comment.
@kumaraditya303 Please read the comment why I check the negotive value
# bpo-46417: Tolerate negative reference count which can occur
# because of bugs in C extensions. This test is only about checking
# the showrefcount feature.
There was a problem hiding this comment.
But I am closing this PR since the #31555 looks better approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue46430