Skip to content

Conversation

flagxor
Copy link

@flagxor flagxor commented Oct 3, 2017

@flagxor flagxor requested a review from a team as a code owner October 3, 2017 06:41
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@flagxor
Copy link
Author

flagxor commented Oct 3, 2017

Signed CLA.

@flagxor
Copy link
Author

flagxor commented Oct 3, 2017

Advice appreciated on what to do with NEWS?
Seems like a minor change. Ideally would get picked to 2.7

@scotchka
Copy link
Contributor

scotchka commented Feb 9, 2019

I think this qualifies for NEWS.

@brettcannon
Copy link
Member

There is a CLA issue with this PR as @bradn123 is the author of the change and they have not signed the CLA due to not having a bugs.python.org account. If they can sign the CLA then we can let this PR in, otherwise we will need to close it for legal reasons.

@flagxor
Copy link
Author

flagxor commented Mar 23, 2019

Ah, done with my other account, but no worries, it looks like someone else has fixed this:
199a280

Closing.

@flagxor flagxor closed this Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants