-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
bpo-15873: Implement [date][time].fromisoformat #4699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
b451a83
Add C implementation of date.fromisoformat
pganssle 4ccef0a
Add python implementation of date.fromisoformat
pganssle 13e8e48
Add tests for date.fromisoformat
pganssle 6fa5c55
Implement C version of datetime.fromisoformat
pganssle 0d44220
Add initial test suite for C-only datetime.fromisoformat
pganssle 327d0fc
Add C implementation of time.fromisoformat()
pganssle 52b2175
Add tests for time.isoformat()
pganssle f1b78af
Add pure python implementation of time.fromisoformat()
pganssle aeaa9ca
Add tests for pure python time.fromisoformat()
pganssle 094ccf4
Add pure python implementation of datetime.fromisoformat
pganssle 2a8120d
Enable tests for pure python datetime.fromisoformat
pganssle af9e6d0
Add documentation for [date][time].fromisoformat()
pganssle cf802af
Consolidate helper functions into parse_digits
pganssle 626d239
Refactor datetime.isoformat round trip tests
pganssle 7c771e7
Refactor C code for PEP 7
pganssle 8fbd752
Add support for seconds in fromisoformat offsets
pganssle 4d55e05
Fix pure python implementation of isoformat() for sub-second zones
pganssle 5a233fb
Add support for subsecond offsets to fromisoformat
pganssle 9fa91db
Fix documentation and pure python error catching in fromisoformat
pganssle ffdb2af
Drop unsupported sep parameter in _tzstr
pganssle 18a5fa8
Add test for ambiguous isoformat strings
pganssle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure why this is not getting hit by the test suite.
test_fromisoformat_fails_typeerror
is designed explicitly to hit this condition. Anyone have an idea why it's getting missed?