Skip to content

gh-91578: error message updated for abstract class #47246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 12, 2022

Conversation

ravi140222
Copy link
Contributor

No description provided.

@bedevere-bot
Copy link

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

@ravi140222 ravi140222 changed the title error message updated for abstract class gh-91578: error message updated for abstract class Apr 15, 2022
@ravi140222
Copy link
Contributor Author

done

@vainaixr
Copy link
Contributor

did I do the entry correctly, is there something else to be done?

@vainaixr
Copy link
Contributor

vainaixr commented May 10, 2022

it gives some assertion errors.
Will have to make the same change for them also.
Will do it by 13th May 2022.

@ravi140222 ravi140222 requested a review from ericvsmith as a code owner May 12, 2022 08:10
@ravi140222
Copy link
Contributor Author

ravi140222 commented May 12, 2022

hopefully it passes this time.
although it appears like a double negative, maybe there should also be a comma in the middle
maybe one of these would solve these problems,

  1. In order to instantiate abstract class X, need to implement abstract methods foo, bar
  2. In order to instantiate abstract class X, need an implementation for abstract methods foo, bar
  3. To instantiate abstract class X, need an implementation for abstract methods foo, bar
  4. Can't instantiate abstract class X, as abstract methods foo, bar are not implemented (but it is again double negative)
  5. Instantiation of abstract class X needs an implementation for abstract methods foo, bar

@ericvsmith
Copy link
Member

I think "Can't instantiate abstract class C with abstract methods foo, bar" reads okay.

@miss-islington
Copy link
Contributor

@ravi140222: Status check is done, and it's a success ✅ .

@ericvsmith ericvsmith merged commit 079f0dd into python:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants