bpo-30579: Docs for dynamic traceback creation #5653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merged this without doc updates prior to beta 1, so this backfills the missing details. The handling of frame and traceback objects in the language reference could stand to be significantly improved in general, but this is a deliberately minimal update in order to cover the changes that were made. |
njsmith
approved these changes
Feb 13, 2018
|
Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 13, 2018
(cherry picked from commit aec7532) Co-authored-by: Nick Coghlan <[email protected]>
|
GH-5655 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Feb 13, 2018
(cherry picked from commit aec7532) Co-authored-by: Nick Coghlan <[email protected]>
merwok
reviewed
Dec 29, 2018
| @@ -198,16 +198,23 @@ Standard names are defined for the following types: | |||
| Defaults to ``None``. Previously the attribute was optional. | |||
|
|
|||
|
|
|||
| .. data:: TracebackType | |||
| .. class:: TracebackType(tb_next, tb_frame, tb_lasti, tb_lineno) | |||
There was a problem hiding this comment.
In class directives, things in parens should be base classes, not constructor parameters.
There was a problem hiding this comment.
@merwok This PR is old enough now that fixing the markup here is likely better handled as a separate issue on the tracker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue30579