bpo-33591: Fix CDLL to accept PathLike objects

[mrh1997]

CDLL (and WinDLL, OleDLL, ...) accept now not only str objects but also PathLike objects.

https://bugs.python.org/issue33591

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again to your contribution and we look forward to looking at it!

[mrh1997]

I signed the CLA (my bugtracker name is "mrh1997").
Please remove the "CLA not signed label"

[JelleZijlstra]

I'm sorry this PR took so long to review. I dug it up from page 57 of the open PR list, but I think it's pretty close to ready.

I do have some comments:

• https://docs.python.org/3.10/library/ctypes.html#ctypes.CDLL should have a "versionchanged" notice saying that starting in version 3.11, PathLike objects are also supported. A similar example note is the one in https://docs.python.org/3.10/library/shutil.html#shutil.move for 3.9. The note should also be added to the other *DLL classes.
• I'd suggest rewording the NEWS entry as:

:class:`ctypes.CDLL`, :class:`ctypes.OleDLL`, :class:`ctypes.WinDLL`,
and :class:`ctypes.PyDLL` now accept :term:`path-like objects
<path-like object>` as their ``name`` argument. Patch by Robert Hoelzl.

[iritkatriel]

This has merge conflicts now.

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[ghost]

All commit authors signed the Contributor License Agreement.

[arhadthedev]

@mrh1997 Could you sign the new CLA by clicking not signed button in the cpython-cla-bot's message, please?

No longer has merge conflicts

[arhadthedev]

Non-Linux tests failed with the following error:

======================================================================
ERROR: test_load (test.test_ctypes.test_loading.LoaderTest.test_load)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\test_ctypes\test_loading.py", line 44, in test_load
    CDLL(CTypesTestPathLikeCls())
  File "D:\a\cpython\cpython\Lib\ctypes\__init__.py", line 367, in __init__
    if '/' in name or '\\' in name:
       ^^^^^^^^^^^
TypeError: argument of type 'CTypesTestPathLikeCls' is not iterable

I'm investigating it.

[arhadthedev]

Fixed; there were two missed lines that continued to use name function argument directly instead of stringified self._name.

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[arhadthedev]

I have made the requested changes; please review again.