bpo-34201: Make ndarray.readonly a bool and use stricter tests in test_buffer. #8414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettcannon
approved these changes
Jul 24, 2018
skrah
reviewed
Jul 26, 2018
| def verify(self, result, *, obj, | ||
| itemsize, fmt, readonly, | ||
| ndim, shape, strides, | ||
| lst, sliced=False, cast=False): | ||
| # Verify buffer contents against expected values. Default values |
There was a problem hiding this comment.
The comment that gives the rationale for the curious initialization no longer applies.
| @@ -978,7 +978,7 @@ def match(req, flag): | |||
| lst = nd.tolist() | |||
|
|
|||
| # The consumer may have requested default values or a NULL format. | |||
| ro = 0 if match(req, PyBUF_WRITABLE) else ex.readonly | |||
| ro = not match(req, PyBUF_WRITABLE) and ex.readonly | |||
There was a problem hiding this comment.
Could you please use the previous version, just replacing 0 with False?
I can accept not p or q for implication, but this goes too far IMHO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34201