Skip to content

gh-88116: Enhance the inspect frame APIs to use the extended position information #91531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2022

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Apr 14, 2022

Automerge-Triggered-By: GH:pablogsal

@JelleZijlstra JelleZijlstra changed the title gh-88166: Enhance the inspect frame APIs to use the extended position information gh-88116: Enhance the inspect frame APIs to use the extended position information Apr 14, 2022
@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@pablogsal
Copy link
Member Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@gpshead: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from gpshead April 22, 2022 12:02
Copy link
Member

@isidentical isidentical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we actually consider adding a deprecation warning on __getitem__ etc?

@pablogsal
Copy link
Member Author

pablogsal commented Apr 22, 2022

LGTM. Should we actually consider adding a deprecation warning on __getitem__ etc?

I thought about it but people had reservations in python-dev so I think we can leave as is

@JelleZijlstra JelleZijlstra self-requested a review April 22, 2022 15:37
@miss-islington
Copy link
Contributor

@pablogsal: Status check is done, and it's a failure ❌ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants