-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-88116: Enhance the inspect frame APIs to use the extended position information #91531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sition information
Misc/NEWS.d/next/Library/2022-04-14-13-11-37.gh-issue-88116.j_SybE.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Jelle Zijlstra <[email protected]>
When you're done making the requested changes, leave the comment: |
I have made the requested changes; please review again |
Thanks for making the requested changes! @gpshead: please review the changes made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Should we actually consider adding a deprecation warning on __getitem__
etc?
I thought about it but people had reservations in python-dev so I think we can leave as is |
Co-authored-by: Jelle Zijlstra <[email protected]>
@pablogsal: Status check is done, and it's a failure ❌ . |
Automerge-Triggered-By: GH:pablogsal