Skip to content

gh-69093: sqlite3 blob doc amendments #91561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 16, 2022
Merged

gh-69093: sqlite3 blob doc amendments #91561

merged 5 commits into from
Apr 16, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 15, 2022 •
edited
Loading

  • document that you cannot open a blob handle in a WITHOUT ROWID table
  • document the blobopen() positional arguments in the same order as they
    appear
  • relocate sqlite3.Blob class section

pythongh-69093: sqlite3 blob doc amendments
dbdf25f 
- document that you cannot open a blob handle in a WITHOUT ROWID table
- document the blobopen() positional arguments in the same order as they
  appear
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Apr 15, 2022
@erlend-aasland erlend-aasland mentioned this pull request Apr 15, 2022
Merged
dholth
dholth approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@dholth dholth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr is more clear, thanks

Also integer primary key: https://www.sqlite.org/rowidtable.html

JelleZijlstra
JelleZijlstra reviewed Apr 15, 2022
View reviewed changes
@erlend-aasland erlend-aasland mentioned this pull request Apr 16, 2022
Merged
@JelleZijlstra JelleZijlstra merged commit 95573ad into python:main Apr 16, 2022
@erlend-aasland erlend-aasland deleted the sqlite-blob-improve-docs branch April 16, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

+1 more reviewer

@dholth dholth dholth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @dholth @JelleZijlstra @bedevere-bot