Skip to content

gh-92107: Forbid specialization of namedtuple types #92117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

gh-92107: Forbid specialization of namedtuple types #92117

wants to merge 3 commits into from

Conversation

serhiy-storchaka
Copy link
Member

Closes #92107.

@serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement topic-typing labels May 1, 2022
@serhiy-storchaka serhiy-storchaka marked this pull request as draft May 1, 2022 14:51
@serhiy-storchaka
Copy link
Member Author

There was found a bug in tests: SplitResult and ParseResult are not generic, according to typeshed.

#92115 is required to make new tests passing.

@serhiy-storchaka serhiy-storchaka marked this pull request as ready for review May 2, 2022 05:31
@JelleZijlstra
Copy link
Member

As discussed on the issue, we should keep allowing this. Could you instead add tests that ensure specialization works?

@serhiy-storchaka
Copy link
Member Author

Closed in favor of #92304.

@serhiy-storchaka serhiy-storchaka deleted the collections-namedtuple-non-generic branch May 4, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees
No one assigned
Labels
awaiting core review topic-typing type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specialization of namedtuple types
3 participants
@serhiy-storchaka @JelleZijlstra @bedevere-bot