[3.9] gh-92112: Fix crash triggered by an evil custom mro() (GH-92113)
#92372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ythonGH-92113). (cherry picked from commit 85354ed) Co-authored-by: Alexey Izbyshev <[email protected]>
bedevere-bot
added
type-crash
JelleZijlstra
commented
May 6, 2022
|
Doesn't look like the fix actually succeeded? |
|
Yeah I think I messed up the backport and I procrastinated fixing it. I can look into it tonight (California time), though maybe that's too late for the next 3.9 release. |
|
The release I'll be cutting tonight is the last 3.9 bugfix release. |
|
Thanks, @JelleZijlstra! |
|
Thanks for checking in! Fortunately it was a simple fix. |
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…ythonGH-92113) (pythonGH-92372) (cherry picked from commit 85354ed) Co-authored-by: Alexey Izbyshev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 85354ed)
Co-authored-by: Alexey Izbyshev [email protected]