-
-
Notifications
You must be signed in to change notification settings - Fork 32k
Doc: Update references and examples of old, unsupported OSes and uarches #92791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6032ecb
534de62
2a67a2a
7fc91e7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,7 +53,7 @@ Cross Platform | |
|
||
.. function:: machine() | ||
|
||
Returns the machine type, e.g. ``'i386'``. An empty string is returned if the | ||
Returns the machine type, e.g. ``'AMD64'``. An empty string is returned if the | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it what returned on the AMD processors? On my computer it is 'x86_64'. Update also the docstring of platform.machine(). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The original 'proper' name of what is also called the "x86-64" architecture is AMD64, as it was created by AMD and later adopted by Intel when Intel's IA-64 (Itanium) architecture failed in the market. What is returned depends (AFAIK) on the OS, not the CPU; Windows and many (most?) Linux distros call it
I can, but as this PR currently only modifies the docs, I'd rather do that separately; there are other places in the codebase that should be updated too, for consistency. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Docstrings are a part of the docs. If we do not update them together with the rst files, they are left desynchronized. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This only affects the choice of one specific example, both of which are equally accurate and valid, and which will be synchronized if and when I do a similar pass through the codebase itself. Several of the other Given the change was minor and not strictly required in the first place, and I almost didn't make it, if this is going to be a big issue I'll just drop this change instead, since its not at all worth the cost. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Either way the docstrings and the documentation should be consistent. |
||
value cannot be determined. | ||
|
||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,7 +37,7 @@ Large File Support | |
|
||
.. sectionauthor:: Steve Clift <[email protected]> | ||
|
||
Several operating systems (including AIX, HP-UX and Solaris) provide | ||
Several operating systems (including AIX and Solaris) provide | ||
support for files that are larger than 2 GiB from a C programming model where | ||
:c:type:`int` and :c:type:`long` are 32-bit values. This is typically accomplished | ||
by defining the relevant size and offset types as 64-bit values. Such files are | ||
|
Uh oh!
There was an error while loading. Please reload this page.