Skip to content

gh-92986: Fix ast.unparse when ImportFrom.level is None #92992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2022

Conversation

hauntsaninja
Copy link
Contributor

This doesn't happen naturally, but is allowed by the ASDL and compiler.
We don't want to change ASDL for backward compatibility reasons
(#57645, #92987)

This doesn't happen naturally, but is allowed by the ASDL and compiler.
We don't want to change ASDL for backward compatibility reasons
(python#57645, python#92987)
@hauntsaninja hauntsaninja marked this pull request as ready for review May 19, 2022 23:02
@hauntsaninja hauntsaninja requested a review from isidentical as a code owner May 19, 2022 23:02
@hauntsaninja
Copy link
Contributor Author

Bump :-) cc @isidentical

@hauntsaninja hauntsaninja added 3.11 only security fixes 3.10 only security fixes 3.12 only security fixes needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes and removed 3.11 only security fixes 3.10 only security fixes 3.12 only security fixes labels Jul 17, 2022
Copy link
Member

@isidentical isidentical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isidentical isidentical merged commit 200c9a8 into python:main Sep 5, 2022
@miss-islington
Copy link
Contributor

Thanks @hauntsaninja for the PR, and @isidentical for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @hauntsaninja and @isidentical, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 200c9a8da0e2b892c476807e986009c01327e781 3.11

@bedevere-bot
Copy link

GH-96592 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 5, 2022
…GH-92992)

This doesn't happen naturally, but is allowed by the ASDL and compiler.
We don't want to change ASDL for backward compatibility reasons
(pythonGH-57645, pythonGH-92987)
(cherry picked from commit 200c9a8)

Co-authored-by: Shantanu <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 5, 2022
@bedevere-bot
Copy link

GH-96593 is a backport of this pull request to the 3.11 branch.

isidentical pushed a commit to isidentical/cpython that referenced this pull request Sep 5, 2022
…ythonGH-92992)

This doesn't happen naturally, but is allowed by the ASDL and compiler.
We don't want to change ASDL for backward compatibility reasons
(pythonGH-57645, pythonGH-92987)
(cherry picked from commit 200c9a8)

Co-authored-by: Shantanu <[email protected]>
miss-islington added a commit that referenced this pull request Sep 5, 2022
This doesn't happen naturally, but is allowed by the ASDL and compiler.
We don't want to change ASDL for backward compatibility reasons
(GH-57645, GH-92987)
(cherry picked from commit 200c9a8)

Co-authored-by: Shantanu <[email protected]>
isidentical added a commit that referenced this pull request Sep 6, 2022
) (GH-96593)

This doesn't happen naturally, but is allowed by the ASDL and compiler.
We don't want to change ASDL for backward compatibility reasons
(GH-57645, GH-92987)
(cherry picked from commit 200c9a8)

Co-authored-by: Shantanu <[email protected]>

Co-authored-by: Shantanu <[email protected]>
@hauntsaninja hauntsaninja deleted the import-from-ast-unparse branch September 15, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants