GH-93112: Fix missing ResourceDenied import in test_urllib2net #93113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
I believe this won't need a news entry - but it should probably be backported to 3.11 and 3.10? |
|
I confirm the bug without the fix: |
vstinner
added
needs backport to 3.10
yes, bugfixes are backported to stable branches: https://devguide.python.org/#status-of-python-branches |
vstinner
approved these changes
May 23, 2022
|
Right. Both are already used in the file, so I didn't know what to prefer. Happy to adjust if you prefer using |
|
Thanks @The-Compiler for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-93168 is a backport of this pull request to the 3.11 branch. |
|
GH-93169 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 24, 2022
…ythonGH-93113) The code was moved out of test.support in 311110a (pythonGH-20812), thus making ResourceDenied undefined. (cherry picked from commit 37c9a35) Co-authored-by: Florian Bruhin <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 24, 2022
…ythonGH-93113) The code was moved out of test.support in 311110a (pythonGH-20812), thus making ResourceDenied undefined. (cherry picked from commit 37c9a35) Co-authored-by: Florian Bruhin <[email protected]>
miss-islington
added a commit
that referenced
this pull request
May 24, 2022
) The code was moved out of test.support in 311110a (GH-20812), thus making ResourceDenied undefined. (cherry picked from commit 37c9a35) Co-authored-by: Florian Bruhin <[email protected]>
miss-islington
added a commit
that referenced
this pull request
May 24, 2022
) The code was moved out of test.support in 311110a (GH-20812), thus making ResourceDenied undefined. (cherry picked from commit 37c9a35) Co-authored-by: Florian Bruhin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was moved out of test.support in
311110a (GH-20812), thus making
ResourceDenied undefined.
Closes #93112.