Skip to content

bpo-33649: Clarify protocol_factory as a method parameter #9330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2018
Merged

bpo-33649: Clarify protocol_factory as a method parameter #9330

merged 1 commit into from
Sep 16, 2018

Conversation

kbumsik
Copy link
Contributor

@kbumsik kbumsik commented Sep 15, 2018 •
edited
Loading

https://bugs.python.org/issue33649

Added basic descriptions of protocol_factory and protocol as a parameter and a return value.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 15, 2018
@1st1 1st1 added the skip news label Sep 15, 2018
@1st1
Copy link
Member

1st1 commented Sep 15, 2018

There seems to be an issue with the trailing whitespace:

[1] library/asyncio-eventloop.rst:538: trailing whitespace

Please fix

@kbumsik
Copy link
Contributor Author

kbumsik commented Sep 16, 2018

@1st1 My bad, Fixed. Thank you!

@1st1 1st1 merged commit 5cc583d into python:master Sep 16, 2018
@1st1
Copy link
Member

1st1 commented Sep 16, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kbumsik @1st1 @the-knights-who-say-ni @bedevere-bot