Skip to content

gh-93439: remove redundant argument to loghelper #93440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2022
Merged

gh-93439: remove redundant argument to loghelper #93440

merged 1 commit into from
Jun 3, 2022

Conversation

eendebakpt
Copy link
Contributor

The method loghelper in mathmodule.c contains the redundant argument funcname. The argument is unused since the usage of the argument was removed from a call to math1 in 89f507f (this is a commit 16 years old with 14,785 additions)

Fixes #93439

@hugovk hugovk added the extension-modules C modules in the Modules dir label Jun 2, 2022
@AlexWaygood AlexWaygood requested a review from mdickinson June 2, 2022 19:44
@mdickinson
Copy link
Member

LGTM

FWIW, this is the commit (by @nnorwitz) where the need for the name disappeared: 45e230a

@mdickinson mdickinson merged commit 5a80e85 into python:main Jun 3, 2022
@eendebakpt eendebakpt deleted the log_helper_redundant_argument branch June 3, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

Assignees
No one assigned
Labels
extension-modules C modules in the Modules dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

loghelper in mathmodule.c contains redundant argument
4 participants
@eendebakpt @mdickinson @hugovk @bedevere-bot