Skip to content

gh-84461: Fix test_sqlite for Emscripten/WASI #94125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2022
Merged

gh-84461: Fix test_sqlite for Emscripten/WASI #94125

merged 1 commit into from
Jun 23, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jun 22, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 22, 2022
@tiran
Copy link
Member Author

tiran commented Jun 22, 2022

I got sqlite working on Emscripten, emscripten-core/emscripten#17297

LIBSQLITE3_LIBS="-sUSE_SQLITE3" LIBSQLITE3_CFLAGS="-sUSE_SQLITE3" ../../configure ...

@Mariatta
Copy link
Member

Testing the bedevere issue number linking.

@Mariatta Mariatta changed the title gh-84461: Fix test_sqlite for Emscripten/WASI Fix test_sqlite for Emscripten/WASI Jun 22, 2022
@Mariatta Mariatta changed the title Fix test_sqlite for Emscripten/WASI gh-84461: Fix test_sqlite for Emscripten/WASI Jun 22, 2022
@Mariatta Mariatta changed the title gh-84461: Fix test_sqlite for Emscripten/WASI Fix test_sqlite for Emscripten/WASI Jun 22, 2022
@Mariatta Mariatta changed the title Fix test_sqlite for Emscripten/WASI gh-84461: Fix test_sqlite for Emscripten/WASI Jun 22, 2022
erlend-aasland
erlend-aasland approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tiran tiran merged commit 15bfabd into python:main Jun 23, 2022
@tiran tiran deleted the gh-84461-sqlite-tests branch June 23, 2022 06:31
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 15bfabd1aabb0335f33202b28f96b4e4062b3bce 3.11

@bedevere-bot
Copy link

GH-94157 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees

@tiran tiran

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiran @Mariatta @miss-islington @bedevere-bot @erlend-aasland