gh-94172: urllib.request avoids deprecated key_file/cert_file #94232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The urllib.request module no longer uses the deprecated key_file and cert_file parameter of the http.client module.
vstinner
commented
Jun 24, 2022
| # cert and key file means the user wants to authenticate. | ||
| # enable TLS 1.3 PHA implicitly even for custom contexts. | ||
| if context.post_handshake_auth is not None: | ||
| context.post_handshake_auth = True |
There was a problem hiding this comment.
This post_handshake_auth code is already in _create_https_context(), but I copied Python 3.11 code which also checks again post_handshake_auth after calling load_cert_chain().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The urllib.request module no longer uses the deprecated key_file and
cert_file parameter of the http.client module.