gh-95271: Extract placeholders howto from sqlite3 tutorial #95522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-aasland
added
needs backport to 3.10
bedevere-bot
added
awaiting core review
docs
|
The placeholders howto can get an overhaul in a separate PR; for now, just move it. |
CAM-Gerlach
requested changes
Aug 2, 2022
ezio-melotti
reviewed
Aug 2, 2022
CAM-Gerlach
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
LGTM from me, thanks, aside from what @ezio-melotti pointed out
- plural agreement, as CAM says - more brevity - add wikipedia link to SQL injection attacks
CAM-Gerlach
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
One minor comment, otherwise LGTM for now—thanks @erlend-aasland !
Co-authored-by: CAM Gerlach <[email protected]>
|
I'll wait for Ezio's thumbs-up before landing, since he requested this change in the first place. |
ezio-melotti
reviewed
Aug 3, 2022
Co-authored-by: Ezio Melotti <[email protected]>
|
FYI, landing this tonight (CET). |
|
Thanks for the reviews, both of you! Having more eyes helps 👀 |
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-95677 is a backport of this pull request to the 3.11 branch. |
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this pull request
Aug 4, 2022
…al (pythonGH-95522) Co-authored-by: CAM Gerlach <[email protected]> Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit b24e8b2) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this pull request
Aug 4, 2022
…al (pythonGH-95522) Co-authored-by: CAM Gerlach <[email protected]> Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit b24e8b2) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
|
GH-95678 is a backport of this pull request to the 3.10 branch. |
erlend-aasland
added a commit
that referenced
this pull request
Aug 4, 2022
…-95522) (#95678) Co-authored-by: CAM Gerlach <[email protected]> Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit b24e8b2) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
erlend-aasland
added a commit
that referenced
this pull request
Aug 4, 2022
…-95522) (#95677) Co-authored-by: CAM Gerlach <[email protected]> Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit b24e8b2) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
iritkatriel
pushed a commit
to iritkatriel/cpython
that referenced
this pull request
Aug 11, 2022
…hon#95522) Co-authored-by: CAM Gerlach <[email protected]> Co-authored-by: Ezio Melotti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-95271