Skip to content

gh-95573: Reduce test data size in test_asyncio/test_ssl.py #95668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 5, 2022

Conversation

fantix
Copy link
Contributor

@fantix fantix commented Aug 4, 2022

The error was like:

Task exception was never retrieved
future: <Task finished name='Task-79' coro=<TestSSL.test_create_server_ssl_over_ssl.<locals>.handle_client() done, defined at cpython/Lib/test/test_asyncio/test_ssl.py:1039> exception=OSError(55, 'No buffer space available')>
Traceback (most recent call last):
  File "cpython/Lib/test/test_asyncio/test_ssl.py", line 1042, in handle_client
    data = await reader.readexactly(len(A_DATA))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "cpython/Lib/asyncio/streams.py", line 728, in readexactly
    await self._wait_for_data('readexactly')
  File "cpython/Lib/asyncio/streams.py", line 522, in _wait_for_data
    await self._waiter
  File "cpython/Lib/asyncio/selector_events.py", line 1049, in write
    n = self._sock.send(data)
        ^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 55] No buffer space available

It was suppressed because of this:

with self._silence_eof_received_warning():
self.loop.run_until_complete(start_server())

@fantix fantix requested review from 1st1 and asvetlov as code owners August 4, 2022 19:02
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 4, 2022
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 4, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 4284913 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 4, 2022
@ambv
Copy link
Contributor

ambv commented Aug 5, 2022

Note: all tests with buildbots pass here with 4284913. The red x is due to missing Misc/NEWS, which I fixed now. Additionally, as discussed on GH-95573, I made the smaller buffer only apply on macOS.

@ambv ambv merged commit 3a9e1fd into python:main Aug 5, 2022
@ambv ambv added the needs backport to 3.11 only security fixes label Aug 5, 2022
@miss-islington
Copy link
Contributor

Thanks @fantix for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-95705 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 5, 2022
…thonGH-95668)

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 3a9e1fd)

Co-authored-by: Fantix King <[email protected]>
ambv pushed a commit that referenced this pull request Aug 5, 2022
GH-95705)

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 3a9e1fd)

Co-authored-by: Fantix King <[email protected]>
@fantix fantix deleted the asyncio-test-ssl-size branch August 8, 2022 18:36
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants