gh-95724: change the taskgroup permission notice to reflect who the permission was given to #95730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the permission notice was relative to the current file, which made it unclear if people copying taskgroups.py would also need to gain permission from edgedb
gvanrossum
reviewed
Aug 6, 2022
| @@ -1,4 +1,4 @@ | |||
| # Adapted with permission from the EdgeDB project. | |||
| # Licensed to PSF from the EdgeDB project. | |||
There was a problem hiding this comment.
This would seem to imply that it is unchanged from the EdgeDb version, which isn't the case at all.
There was a problem hiding this comment.
Hmm, I certainly don't want to imply that either
|
Please update the PR title to accurately reflect the proposed change. |
graingert
changed the title
|
@graingert This also needs to be done to test_taskgroups.py |
|
@graingert Please see #95847 for Yury's alternative PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the permission notice was relative to the current file, which made it unclear if people copying taskgroups.py would also need to gain permission from edgedb