Skip to content

GH-95245: Move weakreflist into the pre-header. #95996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 16, 2022

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Aug 15, 2022

A more robust version of #95657 that allows third party code to have managed weakrefs.

@ericsnowcurrently ericsnowcurrently self-requested a review August 15, 2022 16:04
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM (a few minor comments)

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@markshannon markshannon added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed awaiting changes labels Aug 16, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 0dedf78 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 16, 2022
@markshannon markshannon merged commit 5a8c158 into python:main Aug 16, 2022
@markshannon markshannon deleted the move-weakref-to-preheader-2 branch September 26, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants