Skip to content

gh-96254: Add new wasm build target and support a pkg_config_path #96252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented Aug 24, 2022

In relation to: https://discuss.python.org/t/get-ctypes-working-in-emscripten-build/18466, this adds the following:

  • New build target for pthreads support and dynamic linking at the same time
  • Ability to set the PKG_CONFIG_PATH so that submodules can be built too

The PKG_CONFIG_PATH addition seems kinda hacky though. @tiran had suggested another workaround to get this to work. I thought I'd put this out there to see what people thought. It is more explicit than having to find where emscripten has its sysroot though.

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost
Copy link

ghost commented Aug 24, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@rchiodo
Copy link
Author

rchiodo commented Aug 24, 2022

/cc @brettcannon @tiran

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@rchiodo rchiodo changed the title Add new wasm build target and support a pkg_config_path gh-96254: Add new wasm build target and support a pkg_config_path Aug 25, 2022
@brettcannon brettcannon requested a review from tiran August 26, 2022 21:11
@tiran
Copy link
Member

tiran commented Aug 29, 2022

@rchiodo rchiodo closed this Aug 29, 2022
@rchiodo rchiodo deleted the rchiodo/support_pkg_config branch August 29, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants