-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-96696: Fix ResourceWarning in test.test_frame #96831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sweeneyde
commented
Sep 14, 2022
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: ResourceWarning: unclosed file on buildbots from test_frame #96696
I checked that this fails before 1b46d11 and passes after. |
🤖 New build scheduled with the buildbot fleet by @sweeneyde for commit 9d327d9 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
For example, https://buildbot.python.org/all/#/builders/474 is green for the first time in months. |
It was a bit tricky to get a test to fail on older versions. |
Yep, this test case would fail before #95886:
|
Thanks for checking. |
Thanks @sweeneyde for the PR, and @markshannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
GH-96850 is a backport of this pull request to the 3.11 branch. |
(cherry picked from commit 303bd88) Co-authored-by: Dennis Sweeney <[email protected]>
(cherry picked from commit 303bd88) Co-authored-by: Dennis Sweeney <[email protected]>