Skip to content

Conversation

danishprakash
Copy link
Contributor

@danishprakash danishprakash commented Oct 5, 2018

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and the update!

@miss-islington miss-islington merged commit 656d52d into python:master Oct 7, 2018
@miss-islington
Copy link
Contributor

Thanks @danishprakash for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2018
@bedevere-bot
Copy link

GH-9749 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Sorry, @danishprakash, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 656d52dbfde3223cd2a3525d652b6cccb02fa991 3.6

@miss-islington miss-islington self-assigned this Oct 7, 2018
miss-islington added a commit that referenced this pull request Oct 7, 2018
@ned-deily
Copy link
Member

@danishprakash, if you have time and are so inclined, it would be nice if you could do a manual backport to 3.6.

@danishprakash
Copy link
Contributor Author

danishprakash commented Oct 8, 2018

@ned-deily definitely, I assume it requires me to cherry-pick the commit as mentioned above and then open a PR against the 3.6 branch, is that right?

@tirkarthi
Copy link
Member

@danishprakash Yes, you can install cherry_picker from PyPI and run the command mentioned which will help you.

@ned-deily
Copy link
Member

@danishprakash Yes, that's right. You can use follow the process here or just manually use the git cherry-pick command.

@bedevere-bot
Copy link

GH-9755 is a backport of this pull request to the 3.6 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants