-
-
Notifications
You must be signed in to change notification settings - Fork 32k
Fix asyncio policy docs about per interpreter semantics #97618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @kumaraditya303 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
GH-97619 is a backport of this pull request to the 3.11 branch. |
GH-97620 is a backport of this pull request to the 3.10 branch. |
(cherry picked from commit 9a404b1) Co-authored-by: Kumar Aditya <[email protected]>
(cherry picked from commit 9a404b1) Co-authored-by: Kumar Aditya <[email protected]>
(cherry picked from commit 9a404b1) Co-authored-by: Kumar Aditya <[email protected]>
(cherry picked from commit 9a404b1) Co-authored-by: Kumar Aditya <[email protected]>
It would seem to still be useful to qualify "global" somehow, though, in terms of what actual scope it is global in—per process? Per machine? Something else? Otherwise, it is not very meaningful and potentially even confusing on its own, as a non-expert reader might plausibly think it means anywhere from thread-global to machine-global, given "global" can mean different things in different contexts (Python keyword, C concept, and various others). Or, if you do mean to imply the same scope as Python's |
Also, meta sidenote—it looks like on the CPython repo, the default squash merge commit message is set to be the first commit in the PR, rather than the PR title, which leads to the commit message being the rather uninformative "Fixup policy docs" rather than the far more useful "Fix asycio policy docs about per interpreter semantics" PR title. Someone should probably change that... |
That's my fault, normally I edit the commit title when I merge it, but I was in a hurry (too many meetings today). |
No worries, its easy to miss, and it should be fixed for the future to use the PR title by default now that Ezio set the appropriate repo settings |
(cherry picked from commit 9a404b1) Co-authored-by: Kumar Aditya <[email protected]>
No description provided.