gh-97709: Changed reduce to join in mandelbrot one liner, also included newline character #97713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I suggested in issue at link python#97709
|
All commit authors signed the Contributor License Agreement. |
|
Attending @serhiy-storchaka's comment. I have made another pull request, keeping the use of reduce instead join, but still separating lines. I will close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code uses join method, instead of using reduce from functools and string concatenation.
The code also explicitly prints a newline character between each line instead of relying on line wrapping to separate the lines.
Also, since the code is now modified, it's not the one "due to Ulf Bartelt", but "adapted from Ult Bartelt".