gh-94808: cover PyMapping_HasKeyString and PyMapping_HasKey
#98486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdboom
approved these changes
Oct 20, 2022
| @@ -4690,6 +4690,40 @@ get_mapping_items(PyObject* self, PyObject *obj) | |||
| return PyMapping_Items(obj); | |||
| } | |||
|
|
|||
| static PyObject * | |||
| test_mapping_has_key_string(PyObject *self, PyObject *Py_UNUSED(args)) | |||
There was a problem hiding this comment.
Don't we need to call this function from test_capi.py? Or is that automatic?
There was a problem hiding this comment.
It is:
Lines 1185 to 1189 in 964a92c
JelleZijlstra
added
needs backport to 3.10
|
Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-98698 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 26, 2022
…pythonGH-98486) (cherry picked from commit 5d30544) Co-authored-by: Nikita Sobolev <[email protected]>
|
GH-98699 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 26, 2022
…pythonGH-98486) (cherry picked from commit 5d30544) Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Oct 26, 2022
…8486) (cherry picked from commit 5d30544) Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Oct 26, 2022
…8486) (cherry picked from commit 5d30544) Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.