GH-89237: fix hang in proactor subprocess.wait_closed()
#98572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kumaraditya303
commented
Oct 23, 2022
•
kumaraditya303
commented
- Issue: asyncio hang in subprocess wait_closed() on Windows, BrokenPipeError #89237
kumaraditya303
added
type-bug
kumaraditya303
requested review from
1st1,
asvetlov and
gvanrossum
as code owners
kumaraditya303
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 008be56 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
gvanrossum
reviewed
Oct 24, 2022
Misc/NEWS.d/next/Library/2022-10-23-18-30-39.gh-issue-89237.kBui30.rst
Outdated
Show resolved
Hide resolved
gvanrossum
approved these changes
Oct 24, 2022
|
Thanks @kumaraditya303 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-98620 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 24, 2022
…onGH-98572) (cherry picked from commit ad1dc3e) Co-authored-by: Kumar Aditya <[email protected]>
|
GH-98621 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 24, 2022
…onGH-98572) (cherry picked from commit ad1dc3e) Co-authored-by: Kumar Aditya <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Oct 24, 2022
(cherry picked from commit ad1dc3e) Co-authored-by: Kumar Aditya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.