gh-94808: Improve coverage of unicode_find and unicode_rfind
#98648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cammiec91
approved these changes
Oct 25, 2022
JelleZijlstra
approved these changes
Oct 25, 2022
JelleZijlstra
added
needs backport to 3.10
|
Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 25, 2022
pythonGH-98648) (cherry picked from commit b1783bc) Co-authored-by: Nikita Sobolev <[email protected]>
|
GH-98683 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 25, 2022
pythonGH-98648) (cherry picked from commit b1783bc) Co-authored-by: Nikita Sobolev <[email protected]>
|
GH-98684 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Oct 26, 2022
…98648) (cherry picked from commit b1783bc) Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Oct 26, 2022
…98648) (cherry picked from commit b1783bc) Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lines in
any_find_slicewere not covered:cpython/Objects/unicodeobject.c
Lines 8770 to 8772 in 8aa1e99
cpython/Objects/unicodeobject.c
Lines 8788 to 8790 in 8aa1e99
Now, it is:
findcoversdirection > 0andrfindcoversdirection < 0.This is also related to #98229
But, extra tests won't hurt in any case.