Skip to content

gh-99553: add tests for ExceptionGroup wrapping #99615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 11, 2023
Merged

gh-99553: add tests for ExceptionGroup wrapping #99615

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4b9e01a
gh-99553: clarify doc and add tests
Zac-HD Nov 20, 2022
29b9f27
Update Doc/library/exceptions.rst
Zac-HD Nov 20, 2022
07bdfea
Update Doc/library/exceptions.rst
Zac-HD Nov 21, 2022
9bdb9c6
undo docs changes
hauntsaninja Apr 11, 2023
774b0b8
Merge branch 'main' into zac/custom-exceptiongroup-docs-tests
hauntsaninja Apr 11, 2023
043d002
Merge branch 'main' into zac/custom-exceptiongroup-docs-tests
hauntsaninja Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Lib/test/test_exception_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,20 @@ class MyEG(BaseExceptionGroup, ValueError):
with self.assertRaisesRegex(TypeError, msg):
MyEG("eg", [ValueError(12), KeyboardInterrupt(42)])

def test_EG_and_specific_subclass_can_wrap_any_nonbase_exception(self):
class MyEG(ExceptionGroup, ValueError):
pass

# The restriction is specific to Exception, not "the other base class"
MyEG("eg", [ValueError(12), Exception()])

def test_BEG_and_specific_subclass_can_wrap_any_nonbase_exception(self):
class MyEG(BaseExceptionGroup, ValueError):
pass

# The restriction is specific to Exception, not "the other base class"
MyEG("eg", [ValueError(12), Exception()])


def test_BEG_subclass_wraps_anything(self):
class MyBEG(BaseExceptionGroup):
Expand Down