Skip to content

fnmatch docs: link to fnmatch.filter(), not builtins.filter() #99819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

matthewhughes934
Copy link
Contributor

Fix a link that was pointing to the builtin filter instead of fnmatch.filter

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 27, 2022
Fix a link that was pointing to the builtin `filter` instead of
`fnmatch.filter`
Copy link
Contributor

@slateny slateny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as it matches L45's .filter which links correctly

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood added the needs backport to 3.11 only security fixes label Nov 28, 2022
@AlexWaygood AlexWaygood changed the title Fixup filter link in fnmatch docs fnmatch docs: link to fnmatch.filter(), not builtins.filter() Nov 28, 2022
@AlexWaygood AlexWaygood merged commit ca3e611 into python:main Nov 28, 2022
@miss-islington
Copy link
Contributor

Thanks @matthewhughes934 for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-99849 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 28, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 28, 2022
@AlexWaygood
Copy link
Member

The bug only exists in the main and 3.11 branches.

miss-islington added a commit that referenced this pull request Nov 28, 2022
…H-99819)

(cherry picked from commit ca3e611)

Co-authored-by: Matthew Hughes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants