-
-
Notifications
You must be signed in to change notification settings - Fork 26
Add notes from the 2022-11 meeting #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments, otherwise LGTM
As for the build warning due to Sphinx using the deprecated |
Sphinx is failing on the CI because we're turning warnings into errors (
With pytest, you can disable arbitrary warnings, but looks like Sphinx can only suppress certain ones - is that correct @AA-Turner? Options to fix:
|
This is unfortunate. Would adding A |
Yeah, as mentioned I thought that was already fixed upstream since IIRC we saw it on the PEPs once we started testing on 3.11 (but it didn't block, since we didn't run with
Did you try just If that doesn't work,
is the least bad option, IMO, since it avoids silencing any valid warnings and there isn't a strong pressing need to ensure this runs on 3.11, since AFAIK unlike e.g. the PEPs it doesn't have its own custom theme and Sphinx extensions. |
Bingo! Please see PR #69. |
Co-authored-by: Ezio Melotti <[email protected]> Co-authored-by: Manuel Kaufmann <[email protected]> Co-authored-by: C.A.M. Gerlach <[email protected]>
I missed most of the meeting, so I'm mostly just copying the document here.