-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Use the same token and node class for all string-like literals #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ddfisher We discussed this idea last week... |
Python 3 has separate Str and Bytes ast nodes, so I'm not sure that we want to make this change... |
I think the idea is to have a single node class with the data and a flag or enum giving what form of literal it was. |
Yeah, that was what I gathered. My guess is we'll want to move to Python 3's ast, though, which still has split Str/Bytes nodes. |
But we can still add flags to it I hope?
…--Guido (mobile)
|
Honestly I don't think this is causing much anguish. I'm just going to close it. The status quo is fine. |
It would reduce code duplication if the same class would be used for string and bytes literals (and unicode literals, after they have been implemented). This applies both to tokens and ast nodes.
The text was updated successfully, but these errors were encountered: