`**kwargs` should be of type `Dict[Union[str, unicode], Any]` in Python 2

[rowillia]

If a python 2 file is using from __future__ import unicode_literals breaks reading values out of kwargs using string literals.

Tested using e7ddab1acf44f02d63e8f5d70b1b07c70eeff73b

$ cat > test_kwargs.py << EOL
from __future__ import unicode_literals

def kwargs_func(**kwargs):
  # type: (...) -> str
  return kwargs.get('some_value', '')

kwargs_func(some_value='foo')
EOL

$ mypy --fast-parser --py2 test_kwargs.py
test_kwargs.py: note: In function "kwargs_func":
test_kwargs.py:5: error: Argument 1 to "get" of "dict" has incompatible type "unicode"; expected "str"

[gvanrossum]

Oh, I think the type of **kwargs may have to be made Dict[unicode, ...] instead of Dict[str, ...]. There's probably somewhere in mypy where it does that.

[rowillia]

Thanks @gvanrossum! Out of curiosity, why unicode and not Union[str, unicode]? Shouldn't users be able to access **kwargs via string literals as well as unicode literals?

[gvanrossum]

In mypy, anything that accepts unicode is also deemed to accept str (even though that's a bit of a lie). So the union would be unneeded.

[rowillia]

@gvanrossum Thanks for the explanation! Does that suggest typeshed should use unicode everywhere instead of str? For example:

https://github.com/python/typeshed/blob/39325bf159e9af94e7aad5086b713ec03a23e6a3/stdlib/2and3/argparse.pyi#L49
https://github.com/python/typeshed/blob/746f4db9899dfccb2e236033f6736e1665e1286d/stdlib/2.7/os/__init__.pyi#L12-L13

(We tend to use unicode_literals in our Python Codebase everywhere so this is tripping us up when adopting mypy)

[gvanrossum]

I think the pytype folks would prefer the status quo. Also, we still haven't come up with the final solution for the str/unicode/bytes issue, and it would be better to wait with massive changes until the design is settled. FWIW I think unicode_literals was a bad idea and I now count it as an anti-pattern. Though you may be stuck with it. Still, for `**kwds` mypy should be able to fix this (but it's just me ATM while Jukka is on vacation so don't expect instant fixes).

[rowillia]

@gvanrossum Unfortunately a284c48 didn't fix this issue, it fixed passing a Dict[unicode, Any] in as **kwargs but didn't fix reading values out of **kwargs.

[gvanrossum]

Reopening, since I rolled back PR #1971.