Skip to content

Daemon mode does not preserve trees after first run #4185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JukkaL opened this issue Nov 1, 2017 · 0 comments
Closed

Daemon mode does not preserve trees after first run #4185

JukkaL opened this issue Nov 1, 2017 · 0 comments
Labels
topic-daemon dmypy

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Nov 1, 2017

It seems that daemon does not preserve ASTs in memory after the first run. After subsequent runs this works. I think that the reason for this is that state.meta is None in mypy.build.preserve_cache after the first run.

cc @gvanrossum
@gvanrossum gvanrossum mentioned this issue Nov 1, 2017
Merged
@gvanrossum gvanrossum added the topic-daemon dmypy label Nov 1, 2017
@gvanrossum gvanrossum mentioned this issue Nov 1, 2017
Closed
gvanrossum pushed a commit to gvanrossum/mypy that referenced this issue Nov 1, 2017
Only set self.meta = None when there's an error, not when the interfa…
eef56a9 
…ce is stale. Fixes python#4185
@gvanrossum gvanrossum mentioned this issue Nov 1, 2017
Merged
gvanrossum added a commit that referenced this issue Nov 8, 2017
@gvanrossum
Fix in-memory cache reuse (#4199)
ae374af 
Fixes #4185.
Fixes #4198.
Fixes #4195.
Fixes #4208.

Also some improvements to mypy/incremental_checker.py and report more stats about in-memory cache.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-daemon dmypy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JukkaL @gvanrossum