Skip to content

mypy.codec and typing are not installable for python2 #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
o11c opened this issue Oct 13, 2015 · 7 comments
Closed

mypy.codec and typing are not installable for python2 #917

o11c opened this issue Oct 13, 2015 · 7 comments
Labels

Comments

@o11c
Copy link
Contributor

o11c commented Oct 13, 2015

Working on #915, when mypy is installed rather than run from the current dirrectory, the mypy.codec tests only work in python3 mode because there is no setup.py for python2.

Some previous discussion on #732 and #724.

@o11c
Copy link
Contributor Author

o11c commented Oct 13, 2015

Current thought: move it to mypy_codec package instead of a subpackage.

In the mean time I am XFAILing it so I can work on the rest of the bug.

@o11c
Copy link
Contributor Author

o11c commented Oct 13, 2015

Alternatively: move current setup.py to setup3.py, add a setup2.py, and have setup.py dispatch automatically.

@o11c o11c changed the title mypy.codec is not installable for python2 mypy.codec and typing are not installable for python2 Oct 13, 2015
@o11c
Copy link
Contributor Author

o11c commented Oct 13, 2015

Also affects typing, had to do some nasty hacks to make testpythoneval work for now.

@JukkaL
Copy link
Collaborator

JukkaL commented Oct 13, 2015

I'd rather keep the existing setup.py unmodified and add a separate package mypy-encoding (with a dash instead of an underscore) that supports both Python 2 and Python 3. The official term is Source File Encoding: https://www.python.org/dev/peps/pep-0263/

For typing we need a separate package as well. At some point the idea was to have typing in https://github.com/JukkaL/typing but I haven't that in a while. We'll have to figure this out.

@JukkaL
Copy link
Collaborator

JukkaL commented Oct 13, 2015

Actually, this is multiple independent issues. I'm going to split this into two separate issues.

@JukkaL
Copy link
Collaborator

JukkaL commented Oct 13, 2015

This is now an umbrella task for #919 and #920. I'm keeping this open for now, but further discussion should probably happen under the subtasks.

@gvanrossum
Copy link
Member

No, we should deprecate the codec and delete the code. See my comment in #919.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants