Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5593
Fixes #10024
Fixes #9827
Partially solves #10593 and #11644
This PR moves special cases (introduced by #2407 and #11236) in
SubtypeVisitor.visit_instance
to the end of the func and also adds support forTypedDictType
.Test Plan
A new test case [testTypedDictTempTestName] under the
subtyping
section ofcheck-typeddict.test
. However I don't have an idea about its name.