update: Write certain errors to stderr #1251
Conversation
|
These changes look good to me, but it still prints file not found errors (e.g. |
| print('\n*** INTERNAL ERROR ***') | ||
| print(s.rstrip('\n'), file=sys.stderr) | ||
| print('{}: {}'.format(type(err).__name__, err), file=sys.stderr) | ||
| print('\n*** INTERNAL ERROR ***', file=sys.stderr) |
There was a problem hiding this comment.
I'd argue that it is intentional that the traceback is written to stdout but the final two messages are written to stderr. Though I don't feel strongly.
|
Pin? Are you going to update this PR? |
mrshu
force-pushed
the
mrshu/errors-to-stderr
branch
from
c12d70c to
b06d6b2
Compare
* As described and requested in python#1202, this commit makes errors on command line syntax and files not found to go to stderr rather than stdout. Signed-off-by: mr.Shu <[email protected]>
mrshu
force-pushed
the
mrshu/errors-to-stderr
branch
from
b06d6b2 to
a978ec0
Compare
|
Thanks for the comment @ddfisher, I believe it should be fixed now. @gvanrossum I just did. Please do let me know if you have more comments or other feedback. |
|
David, if you're happy you can merge this. On Thursday, March 3, 2016, Marek Šuppa [email protected] wrote:
--Guido (mobile) |
|
This looks good to me. Thanks! |
update: Write certain errors to stderr
command line syntax and files not found to go to stderr rather than
stdout.
Signed-off-by: mr.Shu [email protected]