Sync typeshed #12766
Sync typeshed #12766
Conversation
Source commit: python/typeshed@b00b4f3
This comment has been minimized.
This comment has been minimized.
|
Note the paroxython change is a true positive. But a tonne of test failures, let's see what's gone wrong. |
|
For reference, we discussed the new homeassistant hit in depth over in python/typeshed#7737. It's a... weird one. |
Source commit: python/typeshed@a27f15e
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The new paroxython error is a true positive, I think it came from one of my regex changes. |
|
The errors are on code that looks like this: return re.sub('[^\\x20-\\x7e]',
lambda m: r'\u%.4x' % ord(m.group(0)), s)Line 345 in 03901ef I suspect mypyc miscompiles this into something involving bytes. |
Mypyc probably somehow believes that the call returns |
Previously we could export an invalid type for a lambda passed to an overloaded function. We find the matching overload variant by type checking the arguments against all overload items. We exported types for lambdas always from the final potential overload item, even if that wasn't the matching one. This could result in mypyc adding invalid type coercions that could result in bogus TypeErrors. The fix is to store types inferred when looking for matching overload items into temporary type maps, and only the type map from the matching item gets merged into the exported types. This doesn't fully solve the problem -- if there are Any types in the arguments, we can still export invalid types. This should be enough to unblock syncing typeshed (#12766). Typeshed started triggering the issue in compiled mypy when re.sub was changed to an overloaded function. Work on #12773.
|
Hopefully #12780 fixes the test failures if you merge master. |
|
Diff from mypy_primer, showing the effect of this PR on open source code: vision (https://github.com/pytorch/vision)
- torchvision/datasets/utils.py:69: error: Argument 1 to "md5" has incompatible type "**Dict[str, bool]"; expected "Union[bytes, Union[bytearray, memoryview, array[Any], mmap, _CData]]" [arg-type]
+ torchvision/datasets/utils.py:69: error: Argument 1 to "md5" has incompatible type "**Dict[str, bool]"; expected "Union[bytes, Union[bytearray, memoryview, array[Any], mmap, _CData, PickleBuffer]]" [arg-type]
paroxython (https://github.com/laowantong/paroxython)
+ paroxython/map_taxonomy.py:223: error: Argument 1 to "append" of "list" has incompatible type "str"; expected "TaxonName"
core (https://github.com/home-assistant/core)
+ homeassistant/util/color.py:300: error: Redundant cast to "float" [redundant-cast]
|
|
Thanks @JukkaL for the fix! |
Source commit:
python/typeshed@a27f15e