Recalculate metaclass in checker.py #13569
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
commented
Aug 31, 2022
There was a problem hiding this comment.
Some thoughts:
- It slow downs all regular classes without
metaclass - It does not solve all our problems. I see a possible case where
metaclassis set to not accurate one because of import cycle
Another idea: maybe we can refactor .metaclass_type to be a @property?
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
No, this is wrong. The problem with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #13565 (comment) for motivation.
I tried hard to come up with a test for this, but I was not successful.
Suggestions are welcome.