Skip to content

Migrate checkstrformat to use ErrorMessage class #15117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Migrate checkstrformat to use ErrorMessage class #15117

wants to merge 2 commits into from

Conversation

tusharsadhwani
Copy link
Contributor

A granular reimplementation of #12004

Changes

  • Migrates error codes in checkstrformat.py to use ErrorMessage objects stored in message_registry
  • Modifies fail method in MessageBuilder to accept ErrorMessage objects (the overload is similar to the one here).

@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@tusharsadhwani
Copy link
Contributor Author

Tagging @hauntsaninja since the self.fail() signature change is based on your code. PTAL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tusharsadhwani