Migrate remaining failure messages to mypy.messages_registry (ircheck.py) #15346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….py) Consolidate .fail() messages into one place (`mypy.message_registry`). This will address python#6116.
for more information, see https://pre-commit.ci
ErrorMessage import was missing ircheck.py
This comment has been minimized.
This comment has been minimized.
Change to ErrorMessage
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
for more information, see https://pre-commit.ci
Migrate remaining failure messages to mypy.messages_registry (semanal_newtype.py). This will address python#6116
This reverts commit 79f8979.
…(semanal_newtype.py)" This reverts commit 4caf8c5.
This comment has been minimized.
This comment has been minimized.
for more information, see https://pre-commit.ci
This reverts commit 57fa031.
for more information, see https://pre-commit.ci
Migrate failure messages (semanal_newtype.py)
for more information, see https://pre-commit.ci
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate .fail() messages into one place (
mypy.message_registry). This will address #6116.I ran the tests using runtest.py as indicated in CONTRIBUTING.md