Make tests runnable on Windows and add appveyor.yaml #1593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waiter depended on a couple of posix tricks. The first was a clever use of os.waitpid(-1, 0) to wait for any spawned processes to return. On Windows, this raises an exception - Windows has no concept of a process group. The second was the use of NamedTempFile(). On anything but Windows, a file can be open for writing and for reading at the same time. This trick actually isn't necessary the way NamedTempFile is used here. It exposes a file-like object pointing to a file already opened in binary mode. All we have to do is seek and read from it.
The only tricky bit of this is renaming python.exe to python2.exe. This is due to util.try_find_python2_interpreter(), which may well need work for Windows since the version symlinks don't exist on Windows.
Most of these fixes revolve around the path separator and the way Windows handles files and locking. There is one bug fix in here - build.write_cache() was using os.rename to replace a file, which fails on Windows. I was only able to fix that for Python 3.3 and up.
(The goal is to avoid having to mark up tests just because they need this kind of translation.)
2 tasks
|
I've just merged this so we have Windows coverage before the (still pending) 0.4.2 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improved version of #1504 by James Tatum(@jtatum) -- I had some feedback but James seems to have dropped out so I am picking up the torch. My contribution is to avoid having to change
[out]to[out pathfix]; instead the test code has to passnative_sep=Truetoparse_test_cases(). The latter function will then translate/to\, but only in the filename part of error messages (the original code just didline.replace('/', '\\'), which would translate slashes in error messages too).Maybe we can get into the upcoming release yet? It doesn't change anything to type checking, and it will make testing on Windows easier and automatic. I've already signed up for appveyor: https://ci.appveyor.com/project/gvanrossum/mypy.