Add exist_ok=True in write_junit_xml #16637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
mypy/util.py
Outdated
| @@ -317,7 +317,7 @@ def write_junit_xml( | |||
| # checks for a directory structure in path and creates folders if needed | |||
| xml_dirs = os.path.dirname(os.path.abspath(path)) | |||
| if not os.path.isdir(xml_dirs): | |||
There was a problem hiding this comment.
Let's remove this condition as it's now redundant.
There was a problem hiding this comment.
True, did remove it.
JelleZijlstra
approved these changes
Dec 8, 2023
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
kourbou
pushed a commit
to kourbou/mypy
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16630