[mypyc] Fix is_native_ref_expr for class attrs #18031
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses mypyc/mypyc#932 in which
in some cases before we were incorrectly not determining that the symbol was native.
Because the problematic implementation of
is_native_ref_expr
is present in multiple places,the one in
builder.py
is rewritten to use the one inmapper.py
.Additional run tests are added to cover the case. Use of a dictionary here prevents falling
under a secondary, more optimized codepath, that avoided the issue entirely.