Suppress errors for unreachable branches in conditional expressions #18295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4134
Fixes #9195
Suppress errors when analyzing unreachable conditional expression branches. Same idea as what's done when analyzing the right-hand operand of
and
/or
:mypy/mypy/checkexpr.py
Lines 4252 to 4256 in 973618a
This PR originally added filters of the same form to the places where
analyze_cond_branch
is called inExpressionChecker.visit_conditional_expr
. However, since 5 out of the 6analyze_cond_branch
call sites now usefilter_errors
for the case whenmap is None
, I decided to move the error filtering logic to insideanalyze_cond_branch
.Given:
Before:
After: