Skip to content

stubtest: understand override #18815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2025
Merged

stubtest: understand override #18815

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9beaaf5
stubtest: understand override
hauntsaninja Mar 19, 2025
73e19e3
assert error
hauntsaninja Mar 19, 2025
bd40f7f
Merge remote-tracking branch 'upstream/master' into stubtover
hauntsaninja Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mypy/stubtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,7 @@ def from_overloadedfuncdef(stub: nodes.OverloadedFuncDef) -> Signature[nodes.Arg

all_args: dict[str, list[tuple[nodes.Argument, int]]] = {}
for func in map(_resolve_funcitem_from_decorator, stub.items):
assert func is not None
assert func is not None, "Failed to resolve decorated overload"
args = maybe_strip_cls(stub.name, func.arguments)
for index, arg in enumerate(args):
# For positional-only args, we allow overloads to have different names for the same
Expand Down Expand Up @@ -1330,6 +1330,7 @@ def apply_decorator_to_funcitem(
if (
decorator.fullname in ("builtins.staticmethod", "abc.abstractmethod")
or decorator.fullname in mypy.types.OVERLOAD_NAMES
or decorator.fullname in mypy.types.OVERRIDE_DECORATOR_NAMES
or decorator.fullname in mypy.types.FINAL_DECORATOR_NAMES
):
return func
Expand Down